[TypeDeclaration] Skip ArrayDimFetch for return and param types#5059
Merged
samsonasik merged 2 commits intorectorphp:mainfrom Sep 21, 2023
Merged
[TypeDeclaration] Skip ArrayDimFetch for return and param types#5059samsonasik merged 2 commits intorectorphp:mainfrom
samsonasik merged 2 commits intorectorphp:mainfrom
Conversation
staabm
changed the title
Contributor
Author
|
@samsonasik please see the failing tests |
Member
|
should be covered by #5058, please rebase |
clxmstaab
force-pushed
the
shape-tests
branch
from
8c503a8 to
8322d2f
Compare
Member
|
It seems green, I am merging it ;) |
Contributor
Author
|
Excellent - thanks 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as proposed in #5056 (comment)