Deprecate BinarySwitchToIfElseRector as opinionated to allow more suitable match() refactoring#5064
Merged
TomasVotruba merged 1 commit intomainfrom Sep 22, 2023
Merged
Conversation
…table match() refactoring
Member
|
/cc @jlherren FYI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rule had a meaning back in PHP 7.4, but now it removes option to manual refactoring to
matchfomr PHP 8.0, that is more often sutiable. Even if it requires manual workaround with predefined value above the switch.Let's give the option back, as
matchis much easier to read and work with 🙂Ref #5057 (comment)