Feature/fix class annotation bad print#5081
Conversation
|
Looking at the errors, it seems your branch is not synced, you need to rebase to latest main branch |
add the Identifier when parent is not PhpDocTagNode (first level annotation)
85d7d63 to
dec82cb
Compare
|
just did it. |
|
It seems cause error, see https://github.com/rectorphp/rector-src/actions/runs/6304413778/job/17115709880?pr=5081#step:7:173 |
|
I didn't see these tests while running |
2d955de to
94d8fb0
Compare
fix bad revert Fix phpStan and cs
94d8fb0 to
85ec5a9
Compare
|
Finally good ! I finally reverted Edit: Ah but now the unit tests I added are not enough as I added them for |
2dd4ed8 to
e1bb82f
Compare
e1bb82f to
09ef3c4
Compare
|
Thank you 👏 |
the command
composer complete-checkstill throw 11 errors but not related to what i changed, so let me know if I have to fix these or not.That's my first PR on a public repo so let me know if I messed something.