Skip to content

Feature/fix class annotation bad print#5081

Merged
TomasVotruba merged 4 commits intorectorphp:mainfrom
etshy:feature/fix-class-annotation-bad-print
Sep 26, 2023
Merged

Feature/fix class annotation bad print#5081
TomasVotruba merged 4 commits intorectorphp:mainfrom
etshy:feature/fix-class-annotation-bad-print

Conversation

@etshy
Copy link
Copy Markdown
Contributor

@etshy etshy commented Sep 25, 2023

the command composer complete-check still throw 11 errors but not related to what i changed, so let me know if I have to fix these or not.

That's my first PR on a public repo so let me know if I messed something.

@etshy etshy requested a review from TomasVotruba as a code owner September 25, 2023 18:37
@samsonasik
Copy link
Copy Markdown
Member

Looking at the errors, it seems your branch is not synced, you need to rebase to latest main branch

add the Identifier when parent is not PhpDocTagNode (first level annotation)
@etshy etshy force-pushed the feature/fix-class-annotation-bad-print branch from 85d7d63 to dec82cb Compare September 25, 2023 20:16
@etshy
Copy link
Copy Markdown
Contributor Author

etshy commented Sep 25, 2023

just did it.
I don't use rebase usually so i hope I didn't mess everything.

@samsonasik
Copy link
Copy Markdown
Member

@etshy
Copy link
Copy Markdown
Contributor Author

etshy commented Sep 25, 2023

I didn't see these tests while running vendor/bin/phpunit, how could I run the tests of the "subpackages" like rector-doctrine or rector-symfony ?

@samsonasik
Copy link
Copy Markdown
Member

@etshy etshy force-pushed the feature/fix-class-annotation-bad-print branch from 2d955de to 94d8fb0 Compare September 25, 2023 22:14
@etshy etshy force-pushed the feature/fix-class-annotation-bad-print branch from 94d8fb0 to 85ec5a9 Compare September 25, 2023 22:21
@etshy
Copy link
Copy Markdown
Contributor Author

etshy commented Sep 25, 2023

Finally good !
Sorry for the email/notif.

I finally reverted DoctrineAnnotationTagValueNode, the probleme didn't really came from here, but from ArrayItemNode with DoctrineAnnotationTagValueNode as value.

Edit: Ah but now the unit tests I added are not enough as I added them for DoctrineAnnotationTagValueNode...
I'll move these tests to ArrayItemNodeTest

@etshy etshy force-pushed the feature/fix-class-annotation-bad-print branch from 2dd4ed8 to e1bb82f Compare September 25, 2023 22:34
@etshy etshy force-pushed the feature/fix-class-annotation-bad-print branch from e1bb82f to 09ef3c4 Compare September 25, 2023 22:36
@TomasVotruba
Copy link
Copy Markdown
Member

Thank you 👏

@TomasVotruba TomasVotruba merged commit 50e589c into rectorphp:main Sep 26, 2023
@etshy etshy deleted the feature/fix-class-annotation-bad-print branch October 5, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants