Skip to content

[CodeQuality] Skip direct InlineHTML on CompleteMissingIfElseBracketRector#5125

Merged
samsonasik merged 9 commits intomainfrom
direct-html
Oct 6, 2023
Merged

[CodeQuality] Skip direct InlineHTML on CompleteMissingIfElseBracketRector#5125
samsonasik merged 9 commits intomainfrom
direct-html

Conversation

@samsonasik
Copy link
Copy Markdown
Member

Direct HTML usage cause fatal error:

     public function run($value)
     {
-        if ($value) ?>
-            <div>Hello</div>
+        if ($value) {
+        }            <div>Hello</div>
         <?php

and need to be skipped.

@samsonasik
Copy link
Copy Markdown
Member Author

Fixed 🎉

@samsonasik
Copy link
Copy Markdown
Member Author

I added more example on elseif and else for direct inline html

@samsonasik
Copy link
Copy Markdown
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;)

@samsonasik samsonasik merged commit cd0881e into main Oct 6, 2023
@samsonasik samsonasik deleted the direct-html branch October 6, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants