Skip to content

[PhpParser] Reduce AstResolver complexity by move check fileName is null to parseFileNameToDecoratedNodes()#5138

Merged
TomasVotruba merged 4 commits intomainfrom
reduce-complexity-ast-resolver
Oct 7, 2023
Merged

[PhpParser] Reduce AstResolver complexity by move check fileName is null to parseFileNameToDecoratedNodes()#5138
TomasVotruba merged 4 commits intomainfrom
reduce-complexity-ast-resolver

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik samsonasik commented Oct 7, 2023

No description provided.

@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented Oct 7, 2023

All checks have passed 🎉 @TomasVotruba I think it is ready.

@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented Oct 7, 2023

I also removed ClassLikeAstResolver as used internally by AstResolver by move the code block to AstResolver itself, and remove useless empty stmts result on a File as lessly happen.

@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented Oct 7, 2023

All checks have passed 🎉 @TomasVotruba I think it is ready.

@TomasVotruba
Copy link
Copy Markdown
Member

TomasVotruba commented Oct 7, 2023

Amazing cleanup, thanks a lot 👏

@TomasVotruba TomasVotruba merged commit d320ac7 into main Oct 7, 2023
@TomasVotruba TomasVotruba deleted the reduce-complexity-ast-resolver branch October 7, 2023 10:16
samsonasik added a commit that referenced this pull request Oct 10, 2023
@samsonasik
[PhpParser] Reduce AstResolver complexity by move check fileName is n…
d4dc408 
…ull to parseFileNameToDecoratedNodes() (#5138)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samsonasik @TomasVotruba