[DeadCode] Skip key used in next stmt on RemoveUnusedForeachKeyRector

[samsonasik]

Fixes rectorphp/rector#8255

[samsonasik]

Fixed 🎉 /cc @ethernidee

[samsonasik]

All checks have passed 🎉 @TomasVotruba I am merging it ;)

[staabm]

does this mean, the logic only works when the var usage is directly after the loop?

the initial problem also exists on e.g.

<?php

namespace Rector\Tests\DeadCode\Rector\Foreach_\RemoveUnusedForeachKeyRector\Fixture;

final class SkipKeyUsedInNexStmt
{
    function lastKey ($container, $defKey = null) {
        $result = $defKey;

        foreach ($container as $result => $value) {
          // next
        }

       $x = 1;
       $y = 2;

        return $result;
      }
}

[samsonasik]

I mean no, that checked with array_slice() :)

[samsonasik]

The logic is check all next stmts:

        $stmts = array_slice($stmtsAware->stmts, $jumpToKey, null, true);
        return (bool) $this->betterNodeFinder->findVariableOfName($stmts, $variableName);