[CodeQuality][Php70] Handle LocallyCalledStaticMethodToNonStaticRector + ThisCallOnStaticMethodToStaticCallRector must change both method and caller

[samsonasik]

No description provided.

[samsonasik]

It seems ClassReflection is not refreshed (cached) on apply Class_ node:

rector-src/rules/Php70/Rector/MethodCall/ThisCallOnStaticMethodToStaticCallRector.php

Line 131 in 29265ca

$isStaticMethod = $this->staticAnalyzer->isStaticMethod($classReflection, $methodName);

the method target still detected as static while already changed as non-static.

[samsonasik]

Fixed 🎉 not ideal solution, set attribute flag is the simplest solution i found ensuring no flip flop change.

[samsonasik]

All checks have passed 🎉 @TomasVotruba I think it is ready.

[samsonasik]

Ok, I got better solution to use Class_ node to verify target ClassMethod already static 👍

[samsonasik]

All checks have passed 🎉 @TomasVotruba I am merging it ;)