Skip to content

[Php80] Keep single quoted key: 'value' on AnnotationToAttributeRector#5215

Merged
samsonasik merged 2 commits intomainfrom
keep-single-key-value
Oct 29, 2023
Merged

[Php80] Keep single quoted key: 'value' on AnnotationToAttributeRector#5215
samsonasik merged 2 commits intomainfrom
keep-single-key-value

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik samsonasik commented Oct 29, 2023

Continue of PR:

this is for key: 'value' to be kept on AnnotationToAttributeRector, which currently cause invalid change:

-#[GenericAnnotation('sample', itemOperations: 'yes')]
+#[GenericAnnotation('sample', itemOperations: "'yes'")]

@samsonasik
Copy link
Copy Markdown
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 06f806c into main Oct 29, 2023
@samsonasik samsonasik deleted the keep-single-key-value branch October 29, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant