RestoreDefaultNullToNullableTypePropertyRector: skip @readonly phpdoc#5233
Merged
samsonasik merged 2 commits intorectorphp:mainfrom Nov 8, 2023
Merged
RestoreDefaultNullToNullableTypePropertyRector: skip @readonly phpdoc#5233samsonasik merged 2 commits intorectorphp:mainfrom
@readonly phpdoc#5233samsonasik merged 2 commits intorectorphp:mainfrom
Conversation
samsonasik
approved these changes
Nov 8, 2023
Member
|
Thank you @staabm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before this fix rector changed the code in a way which makes phpstan error
https://getrector.com/demo/3501e2b7-8e44-44fa-8d2f-b954e3320d60
https://phpstan.org/r/19c64f77-e460-43c8-b504-70f73f3446e6