Skip to content

Completely remove __get() method on AbstractRector #5245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Nov 12, 2023
Merged

Completely remove __get() method on AbstractRector #5245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 0 additions & 29 deletions src/Rector/AbstractRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,35 +71,6 @@ abstract class AbstractRector extends NodeVisitorAbstract implements RectorInter

private ?int $toBeRemovedNodeId = null;

/**
* @var array<string, object>
*/
private array $deprecatedDependencies = [];

/**
* @var array<class-string, array<string, bool>>
*/
private array $cachedDeprecatedDependenciesWarning = [];

/**
* Handle deprecated dependencies compatbility
*/
public function __get(string $name): mixed
{
if (! isset($this->cachedDeprecatedDependenciesWarning[static::class][$name])) {
echo sprintf(
'Get %s property from AbstractRector on %s is deprecated, inject via __construct() instead',
$name,
static::class
);
echo PHP_EOL;

$this->cachedDeprecatedDependenciesWarning[static::class][$name] = true;
}

return $this->deprecatedDependencies[$name] ?? null;
}

public function autowire(
NodeNameResolver $nodeNameResolver,
NodeTypeResolver $nodeTypeResolver,
Expand Down