Skip to content

[Php80] Fix end slash regex on AttributeValueResolver#6579

Merged
samsonasik merged 10 commits intomainfrom
fix-end-slash-regex
Dec 13, 2024
Merged

[Php80] Fix end slash regex on AttributeValueResolver#6579
samsonasik merged 10 commits intomainfrom
fix-end-slash-regex

Conversation

@samsonasik
Copy link
Member

\r? end cause mac os new line detected, it will allow:

some with \

which should not.

@samsonasik
Copy link
Member Author

also updated explode to use our NewLineSplitter to ensure windows \r\n new line included on explode, not part of existing line that cause left over \r

@samsonasik
Copy link
Member Author

I added test for it, if after \, no new line, then keep it as a character, also add test for with new line without other text

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 3001e72 into main Dec 13, 2024
41 checks passed
@samsonasik samsonasik deleted the fix-end-slash-regex branch December 13, 2024 12:21
@github-actions
Copy link
Contributor

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant