[Php80] Keep numeric string, string "true", "false" as is on StringAnnotationToAttributeMapper

[samsonasik]

Fixes rectorphp/rector#8941

[samsonasik]

@Seldaek I will let @TomasVotruba decide on this.

For special doctrine to convert "true" to true, there is already DoctrineConverterAttributeDecorator that cover that

rector-src/rules/Php80/AttributeDecorator/DoctrineConverterAttributeDecorator.php

Lines 33 to 43 in 72c537a

	if (! $value instanceof String_) {
	continue;
	}
	if (! in_array($value->value, ['true', 'false'], true)) {
	continue;
	}
	$arg->value = $value->value === 'true' ? new ConstFetch(new Name('true')) : new ConstFetch(new Name(
	'false'
	));

and used only on AnnotationToAttributeRector for special doctrine purpose as AttributeGroupNamedArgumentManipulator

The TestWithAnnotationToAttributeRector rule doesn't use AttributeGroupNamedArgumentManipulator.

[samsonasik]

All checks have passed 🎉 @TomasVotruba it is ready for review.

[Seldaek]

Thanks, I don't have enough historical context here to say what's most sensible so I'll leave you two to figure it out :)

[TomasVotruba]

It seems it doesn't break any other annotation to attribute conversions, so let's give it a try :) 👍

[samsonasik]

Thank you @TomasVotruba, I will check use of AttributeGroupNamedArgumentManipulator on rector-doctrine on special use cases, eg: nullable: "true" which seems need to be used on specific rule that require the transformation

[github-actions]

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.