[DX] Use Param->isPromoted() over param->flags !== 0 check on promotion property check#6646
Merged
samsonasik merged 2 commits intomainfrom Jan 5, 2025
Merged
[DX] Use Param->isPromoted() over param->flags !== 0 check on promotion property check#6646samsonasik merged 2 commits intomainfrom
samsonasik merged 2 commits intomainfrom
Conversation
Member
Author
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
->isPromoted()cover!==0and property hook on php 8.4, also easier to verify instead of remember what!==0means.see https://github.com/nikic/PHP-Parser/blob/7d3039c37823003d576247868fe755f3d7ec70b8/lib/PhpParser/Node/Param.php#L67-L73