Skip to content

Add readonly by default on new promoted property#6650

Merged
TomasVotruba merged 1 commit intomainfrom
tv-readonly-add-ctor
Jan 5, 2025
Merged

Add readonly by default on new promoted property#6650
TomasVotruba merged 1 commit intomainfrom
tv-readonly-add-ctor

Conversation

@TomasVotruba
Copy link
Member

No description provided.

@TomasVotruba TomasVotruba force-pushed the tv-readonly-add-ctor branch 2 times, most recently from 660f983 to 659e2a3 Compare January 5, 2025 17:15
@samsonasik
Copy link
Member

@TomasVotruba we need immediate new rector release due to error on PHPStan 2.1.1, see PR;

should I wait for this one before releasing new tag?

@TomasVotruba
Copy link
Member Author

@samsonasik Yes, let's finish this one first

@samsonasik
Copy link
Member

@TomasVotruba ok, feel free to tag yourself once you finished it,

I am not sure if this will cause BC break without some flag, eg: $markReadonly so you can enable it on service you want to use it.

I guess 2.0.6 or 2.1 :)

@TomasVotruba
Copy link
Member Author

This targets ctors only, where all new dependencies are readonly by default.
Could you share example where this causes break?

@samsonasik
Copy link
Member

Ok, let's see how user will use it, especially on rector extensions, since method is public

/cc @driftingly @peterfox @simonschaufi FYI

@TomasVotruba TomasVotruba merged commit 8bc80b4 into main Jan 5, 2025
41 checks passed
@TomasVotruba TomasVotruba deleted the tv-readonly-add-ctor branch January 5, 2025 17:37
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants