Skip to content

[TypeDeclaration] Skip void return on callback docblock on AddArrowFunctionReturnTypeRector#6780

Merged
samsonasik merged 1 commit intomainfrom
skip-void-callback-doc
Mar 12, 2025
Merged

[TypeDeclaration] Skip void return on callback docblock on AddArrowFunctionReturnTypeRector#6780
samsonasik merged 1 commit intomainfrom
skip-void-callback-doc

Conversation

@samsonasik
Copy link
Member

@samsonasik
Copy link
Member Author

@BackEndTea I handled it by verify native return is mixed, but docblock return is null

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 61cb7b5 into main Mar 12, 2025
44 checks passed
@samsonasik samsonasik deleted the skip-void-callback-doc branch March 12, 2025 15:12
@BackEndTea
Copy link

Thanks @samsonasik !

Copy link
Member

@TomasVotruba TomasVotruba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect behavior of AddArrowFunctionReturnTypeRector when dealing with a generic void return

3 participants