[AutoImport] Allow on FQCN current same class #7232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;) |
Member
Author
|
It seems cause invalid apply on conflict fqcn vs short name last name equal, see https://getrector.com/demo/33737310-3dd2-4e5a-9dce-b14781b11579 Reverting for now. |
samsonasik
added a commit
that referenced
this pull request
Sep 10, 2025
This reverts commit e614730.
samsonasik
added a commit
that referenced
this pull request
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is allowed, see https://3v4l.org/mN8qD
which currently skipped https://getrector.com/demo/0eb40273-c265-4c33-8540-6fe2cfb029b0
This PR allow to use the name if same with current namespace.
namepace App\Bar; class FqcnCurrentSameClass { - public \App\Bar\FqcnCurrentSameClass $prop; + public FqcnCurrentSameClass $prop;This PR handle on namespaced code.