Skip to content

[type-declaration-docblock] kick of docblock rules to help with iterables#7244

Merged
TomasVotruba merged 2 commits intomainfrom
tv-docblock-type-declaration
Sep 11, 2025
Merged

[type-declaration-docblock] kick of docblock rules to help with iterables#7244
TomasVotruba merged 2 commits intomainfrom
tv-docblock-type-declaration

Conversation

@TomasVotruba
Copy link
Member

No description provided.

@TomasVotruba TomasVotruba force-pushed the tv-docblock-type-declaration branch 8 times, most recently from c39b935 to 3f1e40e Compare September 11, 2025 16:01
@TomasVotruba TomasVotruba force-pushed the tv-docblock-type-declaration branch from 3f1e40e to 39bd4d7 Compare September 11, 2025 16:11
@TomasVotruba TomasVotruba enabled auto-merge (squash) September 11, 2025 16:11
@TomasVotruba TomasVotruba merged commit 540d80b into main Sep 11, 2025
49 checks passed
@TomasVotruba TomasVotruba deleted the tv-docblock-type-declaration branch September 11, 2025 16:12
@samsonasik
Copy link
Member

I think the DocblockGetterReturnArrayFromPropertyDocblockVarRector should avoid mixed:

@return mixed[]

or

@return mixed[]|null

as possible, use scalar, iterable, and objects is probably better imo.

@TomasVotruba
Copy link
Member Author

@samsonasik Agreed, we can add mixed[] rule as the very last one, after everything else is applied.
Feel free to add PR to skip it, if mixed[] or mixed[]|null

@samsonasik
Copy link
Member

#7261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants