[type-declaration] Add set, get and static call to KnownMagicClassMethodTypeRector #7422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TomasVotruba
commented
Oct 4, 2025
TomasVotruba
commented
- add scalar types condition
- add call static support, set and get
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-known-magic-method-calls-types-2
branch
from
ac2f93c to
fea5ed6
Compare
TomasVotruba
force-pushed
the
tv-known-magic-method-calls-types-2
branch
from
018ab9e to
addfd97
Compare
samsonasik
reviewed
Oct 4, 2025
| if (! $firstParam->type instanceof Node) { | ||
| $firstParam->type = new Identifier('string'); | ||
| $hasChanged = true; | ||
| if ($this->isNames($classMethod, [MethodName::CALL, MethodName::CALL_STATIC])) { |
Member
There was a problem hiding this comment.
By this change, the parent guard can't early return null, as check match method name moved after, I will create new parent to move below here, or use continue instead.
Member
There was a problem hiding this comment.
I created PR for check parent with other method to continue on it:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.