Add back removed fixture aliased multi properties on AnnotationToAttributeRector #7549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
commented
Oct 23, 2025
rules-tests/Php80/Rector/Class_/AnnotationToAttributeRector/config/configured_rule.php
Outdated
Show resolved
Hide resolved
...hp80/Rector/Class_/AnnotationToAttributeRector/Fixture/aliased_with_multi_properties.php.inc
Outdated
Show resolved
Hide resolved
...hp80/Rector/Class_/AnnotationToAttributeRector/Fixture/aliased_with_multi_properties.php.inc
Outdated
Show resolved
Hide resolved
Member
Author
|
@TomasVotruba I've updated the fixture and source per your suggestion 👍 Ready to merge 👍 |
Member
Author
|
@TomasVotruba let's merge 👍 |
Member
|
Looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TomasVotruba here per #7548 (review)
The original PR that introduce it is at:
The fixture is needed. The case is same name in both annotation and attribute, but different namespace, and aliased is imported in multi properties.