[DeadCode] Allow remove @var on expression assign on RemoveUselessVarTagRector #7871
+87
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
force-pushed
the
allow-expression-assign
branch
from
dd2e003 to
2bd4b02
Compare
samsonasik
force-pushed
the
allow-expression-assign
branch
from
519b9a6 to
0f32100
Compare
samsonasik
force-pushed
the
allow-expression-assign
branch
from
fabcc85 to
0b8cb54
Compare
samsonasik
force-pushed
the
allow-expression-assign
branch
from
c941f49 to
46e986c
Compare
samsonasik
force-pushed
the
allow-expression-assign
branch
from
3fcf153 to
a62b354
Compare
samsonasik
force-pushed
the
allow-expression-assign
branch
from
053c633 to
d46a785
Compare
Member
Author
|
Fixed 🎉 /cc @Payn , feel free to provide more failing fixture PR to assign expression usage if you found a native vs docblock equal usecase :) |
Member
Author
|
@TomasVotruba ready 👍 |
Member
|
Looks good, thank you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9609