[reporting] Group unused skips by rule, skip reporting on narrowed runs#8069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unused skip reporting: group by rule + avoid false positives
Follow-up to the unused-skip reporting feature.
Group unused paths by rule
Previously each unused rule-scoped skip was printed on its own line, repeating the rule class:
Now multiple paths are grouped under their rule, matching the
->withSkip()config shape:Single-path skips stay on one line as before.
Skip reporting on narrowed runs
A narrowed run only touches part of the codebase, so skips outside that scope look falsely unused and produce many false positives. Unused-skip reporting is now disabled when the run is narrowed via:
bin/rector process app/bundles/PointBundle/Controller/TriggerController.php)--only--only-suffixThis applies to both console and JSON output (both go through
UnusedSkipResolver).