[DeadCode] Keep parent-delegating constructor when its docblock refines parameter types#8111
Merged
Merged
Conversation
…es parameter types
Member
Author
|
LGTM 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
RemoveParentDelegatingConstructorRectorremoves a constructor that only callsparent::__construct(...)with the same arguments — but it ignores the docblock. When the child constructor exists purely to refine parameter types via PHPDoc, removing it silently drops that type information.Reported from
webonyx/graphql-php, which had to skip the rule onCustomScalarType.php(commit5da64b9, "Ignore overzealous rector"):The native signature (
array $config) matches the parent, so the rule considered the constructor redundant and removed it — along with the@param array<string, mixed>/@phpstan-param CustomScalarConfigrefinement. Callers would then be type-checked against the parent's looserarraytype.Fix
Skip removal when the constructor's docblock declares any parameter-type tag (
@param,@phpstan-param,@psalm-param), since that refines types beyond the native signature.Added fixture
skip_param_refining_docblock.php.inc(no-change), which is fully removed without the guard.