fix ControllerMethodInjectionToConstructorRector - update call sites when params are moved to constructor

[TomasVotruba]

Problem

Fixes rectorphp/rector#9695

When a controller has a helper method that takes both a service parameter and optional scalar parameters:

final class SomeController extends AbstractController
{
    #[Route('/some-action')]
    public function someAction(LoggerInterface $logger)
    {
        $this->problematic($logger);
    }

    public function problematic(LoggerInterface $logger, ?string $optional = 'test')
    {
        $logger->log('level', 'value');
        dump($optional);
    }
}

The rule correctly moved LoggerInterface $logger out of both method signatures and into the constructor, and replaced $logger usages inside each method body with $this->logger. However, it did not update the call site $this->problematic($logger) in someAction — after $logger was replaced with $this->logger by the variable-replacement step, the call became $this->problematic($this->logger), even though problematic no longer accepts that argument. This produced invalid code.

Fix

After all param removals and variable replacements, a new updateCallSitesForRemovedParams step traverses every method body in the class. For any $this->methodName(...) call whose method had parameters removed, the corresponding positional arguments are removed from the call.

Changes

• rules/CodeQuality/Rector/Class_/ControllerMethodInjectionToConstructorRector.php — track removed param positions per method; add updateCallSitesForRemovedParams() that strips the stale arguments from internal call sites
• rules-tests/.../Fixture/internal_method_call_arg_removal.php.inc — new fixture reproducing the exact scenario from the issue

---

Generated by Claude Code

[TomasVotruba]

Good job :)