[PHPUnit][Symfony] Make http assert provide more debug content

[TomasVotruba]

 $this->assertEquals(
     Response::HTTP_NO_CONTENT,
     $response->getHttpResponse()->getStatusCode(),
+    $response->getHttpResponse()->getContent()
 );

Dummy Prototype

<?php

use PhpParser\Node;
use Rector\Rector\AbstractRector;
use Rector\RectorDefinition\RectorDefinition;
use Symfony\Component\HttpFoundation\Response;

final class AddErrorContentToAssertRequestRector extends AbstractRector
{
    /**
     * @return string[]
     */
    public function getNodeTypes(): array
    {
        return [Node\Expr\StaticCall::class];
    }

    /**
     * @param Node\Expr\StaticCall $node
     */
    public function refactor(Node $node): ?Node
    {
        if (!$this->isName($node->name, 'assertEquals')) {
            return null;
        }

        // already has "message" argument
        if (isset($node->args[2])) {
            return null;
        }

        // is http request status?
        if (!$node->args[0]->value instanceof Node\Expr\ClassConstFetch) {
            return null;
        }

        /** @var Node\Expr\ClassConstFetch $classConstFetch */
        $classConstFetch = $node->args[0]->value;
        if (!$this->isType($classConstFetch->class, Response::class)) {
            return null;
        }

        // we have a match!
        // @todo - get variable from arg[1]

        $methodCall = $node->args[1]->value;
        $variableName = 'response';
        if ($methodCall instanceof Node\Expr\MethodCall) {
            if ($methodCall->var instanceof Node\Expr\Variable) {
                $variableName = $this->getName($methodCall->var);
            } else {
                $variableName = $this->getName($methodCall->var->var);
            }
        }

        $getHttpResponseMethodCall = new Node\Expr\MethodCall(new Node\Expr\Variable($variableName), 'getHttpResponse');

        $getContentMethodCall = new Node\Expr\MethodCall($getHttpResponseMethodCall, 'getContent');

        $node->args[2] = new Node\Arg($getContentMethodCall);

        return $node;
    }

    public function getDefinition(): RectorDefinition
    {
    }
}

[stloyd]

This should be really optional IMHO as if that page is HTML one, the content is not really useful at all :)

[TomasVotruba]

Don't worry :)

Every rule is optional. Mainly in code-style and combinations - "[x][y]" in the title.

But while we're at it - any idea how to make these cases ignored by the expected header argument?