[PHP 8.1] Add upgrade from resource to objects

[TomasVotruba]

PHP docs: https://www.php.net/manual/en/migration81.incompatible.php

See https://php.watch/articles/resource-object

[samsonasik]

it seems some partially start from php 8, and others start from php 8.1, eg:

Start from PHP 8: curl_init()

➜  rector-src git:(main) ✗ php -v
PHP 8.0.11 (cli) (built: Oct 12 2021 23:08:20) ( NTS )
Copyright (c) The PHP Group
Zend Engine v4.0.11, Copyright (c) Zend Technologies
    with Xdebug v3.0.4, Copyright (c) 2002-2021, by Derick Rethans
    with Zend OPcache v8.0.11, Copyright (c), by Zend Technologies
    
➜  rector-src git:(main) ✗ php -a
Interactive shell

php > $ch = curl_init();
php > var_dump($ch);
object(CurlHandle)#1 (0) {
}

Start from PHP 8.1: finfo_open():

# finfo_open() still returns resource in php 8.0
➜  rector-src git:(main) ✗ php -v
PHP 8.0.11 (cli) (built: Oct 12 2021 23:08:20) ( NTS )
Copyright (c) The PHP Group
Zend Engine v4.0.11, Copyright (c) Zend Technologies
    with Xdebug v3.0.4, Copyright (c) 2002-2021, by Derick Rethans
    with Zend OPcache v8.0.11, Copyright (c), by Zend Technologies

➜  rector-src git:(main) ✗ php -a
Interactive shell

php > $f = finfo_open();
php > var_dump($f);
resource(1) of type (file_info)

# finfo_open() still returns object in php 8.1
➜  rector-src git:(main) ✗ /opt/homebrew/Cellar/php@8.1/8.1.0_3/bin/php -v
PHP 8.1.0RC5-dev (cli) (built: Oct 14 2021 17:12:40) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.0-dev, Copyright (c) Zend Technologies
    with Zend OPcache v8.1.0RC5-dev, Copyright (c), by Zend Technologies

➜  rector-src git:(main) ✗ /opt/homebrew/Cellar/php@8.1/8.1.0_3/bin/php -a
Interactive shell

php > $f = finfo_open();
php > var_dump($f);
object(finfo)#1 (0) {
}

so it needs to be php 8.0 and php 8.1 rector rules.

[samsonasik]

@TomasVotruba I think we may need to differentiate naming between php 8 and php 81 for dx:

php 8 : Php8ResourceToObjectRector for https://www.php.net/manual/en/migration80.incompatible.php#migration80.incompatible.resource2object

php 8.1 : Php81ResourceToObjectRector for https://www.php.net/manual/en/migration81.incompatible.php#migration81.incompatible.resource2object

so when manually used, user don't need to make alias for them.

[samsonasik]

• PHP8 is_resource() to object check implemented at PR [Php80] Add Php8ResourceReturnToObjectRector rector-src#1068