Incorrect behavior of ClassPropertyAssignToConstructorPromotionRector with SensitiveParameter attribute

[mbabker]

Bug Report

Subject	Details
Rector version	0.15.0
Installed as	composer dependency

Minimal PHP Code Causing Issue

See https://getrector.org/demo/cd6191ec-6e65-4c8c-882f-7e69c3ed6808

<?php

final class ApiClient
{
    private readonly string $apiKey;

    public function __construct(
        #[\SensitiveParameter] string $apiKey,
    ) {
        $this->apiKey = $apiKey;
    }
}

Responsible rules

• ClassPropertyAssignToConstructorPromotionRector

Expected Behavior

The SensitiveParameter attribute only targets parameters, so constructor arguments with this attribute should not use property promotion.

[samsonasik]

Could you try provide a patch for it? You can verify with PhpAttributeAnalyzer->hasPhpAttribute, ref
https://github.com/rectorphp/rector-src/blob/25dec6b32504d747ff62193ff4704144ca10b040/rules/Php80/NodeAnalyzer/PhpAttributeAnalyzer.php#L31

[mbabker]

rectorphp/rector-src#3165 seems to work for me

[samsonasik]

Per-discussion on rectorphp/rector-src#3165 (comment)

I re-open it as the actual bug is the attribute group should be kept during converting to property promotion.