Glob wildcard pattern not honored

[chrispmcgee]

Bug Report

Subject	Details
Rector version	v2.2.14

Skipping a rule with regular paths works fine:

    ->withSkip([
        StringClassNameToClassConstantRector::class => [__DIR__ . '/tests/Architecture'],
    ]);

However, when using a glob pattern (fnmatch?), it does not skip the file:

    ->withSkip([
        RequestStaticValidateToInjectRector::class => [
            __DIR__ . '/tests',
            __DIR__ . '/Modules/*/tests',
        ],
    ]);

The rector still changes the files in the various modules' tests directories. (Using Laravel Modules, btw.)

Minimal PHP Code Causing Issue

It's not really reproducible with the online tester because there is no file path for the demo PHP snippet, but here's a close representation:

https://getrector.com/demo/c51e0c83-92f8-4508-a10a-a9d45b2b5e5a

Expected Behaviour

Any file in the root /tests directory, as well as somewhere inside a tests directory under all of the module directories (Modules/Carriers/tests/…, Modules/Loads/tests/…, Modules/Users/tests/…, etc.) should not have the specified rule applied.

[TomasVotruba]

I think the __DIR__ . '/Modules/*/tests', is not a glob.
Either use absolute path or *, they cannot be mixed.

[chrispmcgee]

This same pattern is documented as a way to skip rules.

[TomasVotruba]

Docs should be updated then 👍

[chrispmcgee]

No, they shouldn't. Unless it's to make them a bit more clear, perhaps.

It turns out that I misunderstood how fnmatch works (which I'd never even heard of before Rector) versus how glob works. I assumed that all paths would be scanned recursively. e.g., specifying src/WholeDirectory would scan src/WholeDirectory, src/WholeDirectory/SubDirectory1, src/WholeDirectory/SubDirectory2, src/WholeDirectory/SubDirectory2/NestedDirectory/Way/Deep, etc.

It turns out that if you use a wildcard like * in the pathname, that changes its behavior and it no longer scans recursively unless you specifically tell it to by trailing the path with /*. That was what I missed/misunderstood from the documentation. I don't know enough about fnmatch or glob to know if they behave the same that way; I was just used to the way a non-wildcarded path was searched by default.

So when I replaced '/Modules/*/tests' with '/Modules/*/tests/*' in my config file, it finally scans recursively inside the tests directory of each module.

My apologies for making this mistake and not trying out that trailing /* before posting here.