Skip to content

[PHP 7.4] Add ClosureToArrowFunctionRector#1410

Merged
TomasVotruba merged 1 commit intomasterfrom
array-wip
May 11, 2019
Merged

[PHP 7.4] Add ClosureToArrowFunctionRector#1410
TomasVotruba merged 1 commit intomasterfrom
array-wip

Conversation

@TomasVotruba
Copy link
Copy Markdown
Member

@TomasVotruba TomasVotruba commented May 10, 2019 •
edited
Loading

Closes #1405

-return array_filter($meetups, function (Meetup $meetups) {
+return array_filter($meetups, fn(Meetup $meetup) => is_object($meetup));
-   return is_object($meetup);
-);

@TomasVotruba TomasVotruba force-pushed the array-wip branch 3 times, most recently from 61169a4 to 13d2e1d Compare May 10, 2019 13:32
nikic
nikic reviewed May 10, 2019
View reviewed changes
Comment thread packages/Php/src/Rector/Closure/ClosureToArrowFunctionRector.php
nikic
nikic reviewed May 10, 2019
View reviewed changes
Comment thread packages/Php/src/Rector/Closure/ClosureToArrowFunctionRector.php Outdated
@TomasVotruba TomasVotruba changed the title [WIP] [PHP 7.4] Add ClosureToArrowFunctionRector [PHP 7.4] Add ClosureToArrowFunctionRector May 11, 2019
@TomasVotruba
Copy link
Copy Markdown
Member Author

TomasVotruba commented May 11, 2019

@nikic Thanks, I've included your notes

@TomasVotruba TomasVotruba merged commit 72c278d into master May 11, 2019
@TomasVotruba TomasVotruba deleted the array-wip branch May 11, 2019 12:33
@TomasVotruba TomasVotruba restored the array-wip branch May 23, 2019 05:00
@TomasVotruba TomasVotruba deleted the array-wip branch May 23, 2019 05:00
TomasVotruba added a commit that referenced this pull request Dec 6, 2021
@TomasVotruba
Updated Rector to commit 5493b6d
f3d9b9c 
rectorphp/rector-src@5493b6d [DX] Re-use configure() in docs + remove prefixing of ValueObjectInliner (#1410)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nikic nikic nikic left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[PHP 7.4] Add arrow functions

2 participants

@TomasVotruba @nikic