Skip to content

[ImportFullyQualifiedNamesRector] Allow to opt-out from doc block modification#1412

Merged
TomasVotruba merged 1 commit intorectorphp:masterfrom
mxr576:issue/1409
May 10, 2019
Merged

[ImportFullyQualifiedNamesRector] Allow to opt-out from doc block modification#1412
TomasVotruba merged 1 commit intorectorphp:masterfrom
mxr576:issue/1409

Conversation

@mxr576
Copy link
Copy Markdown
Contributor

@mxr576 mxr576 commented May 10, 2019

Fixes #1409

@mxr576
Copy link
Copy Markdown
Contributor Author

mxr576 commented May 10, 2019

Not sure whether a test coverage is needed for this change. If I should add a test for this, could you please provide me an example of how can I run add one test case to ImportFullyQualifiedNamesRectorTest that runs the rector with a custom configuration, not with the default? I found \Rector\Testing\PHPUnit\AbstractRectorTestCase::getRectorsWithConfiguration() but I am not sure whether there is a correlation between the returned rectors by getRectorsWithConfiguration() and the test files added in test().

@TomasVotruba TomasVotruba merged commit 3c1cf11 into rectorphp:master May 10, 2019
@TomasVotruba
Copy link
Copy Markdown
Member

TomasVotruba commented May 10, 2019

Great job 👍

Test is not needed here. It's pretty clear

TomasVotruba added a commit that referenced this pull request Dec 7, 2021
@TomasVotruba
Updated Rector to commit f66b01e
6f0deef 
rectorphp/rector-src@f66b01e [Core] Fix count files and diff changes on FileProcessor (#1412)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomasVotruba TomasVotruba TomasVotruba approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ImportFullyQualifiedNamesRector: opt-out from docblock modification

2 participants

@mxr576 @TomasVotruba