[PSR-4 Split] Split interfaces and traits as well#1414
Merged
TomasVotruba merged 1 commit intomasterfrom May 12, 2019
Merged
Conversation
Contributor
Author
|
@TomasVotruba before this MR files containing interface and/or trait with class would fail splitting - it deleted non class nodes and did not move them to new files. |
Member
|
Better create new test instead of deleting the old one. It's hard to read PR now |
Contributor
Author
|
Fixed 😉 |
JanMikes
force-pushed
the
split-all-classlike-psr4
branch
from
c4cf354 to
31d2ce4
Compare
Contributor
Author
|
@TomasVotruba can we merge? 😉 |
Member
|
Sure, I didn't have time to review. All the Italian 🍕 🍷 and travelling :D Nice test btw, simple and clear 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.