Merged
Conversation
TomasVotruba
force-pushed
the
spread-array
branch
from
0a7bf97 to
da8bbfc
Compare
TomasVotruba
force-pushed
the
spread-array
branch
4 times, most recently
from
8c6b57d to
e2fba5c
Compare
|
Hi Tomas Thanks for this PR. I used rector on a projet of mine and I saw this diff. The new version (spread array) is slower. And the new version is not necessary more readable. |
Member
Author
|
Hi, how would people know about optional sets? It's like optional dependency. Also, could you test with opcodes? I recall there was some difference about it in RFC. |
Member
Author
|
Thank you for performance testing 👍 |
TomasVotruba
added a commit
that referenced
this pull request
Dec 7, 2021
rectorphp/rector-src@4ca7e3f Disable workflows unsuited for forks (#1416)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1411