Skip to content

[CodeQuality] Add CompactToVariablesRector#1443

Merged
TomasVotruba merged 2 commits intomasterfrom
code-quality-compact
May 19, 2019
Merged

[CodeQuality] Add CompactToVariablesRector#1443
TomasVotruba merged 2 commits intomasterfrom
code-quality-compact

Conversation

@TomasVotruba
Copy link
Copy Markdown
Member

@TomasVotruba TomasVotruba commented May 19, 2019

Closes #1379

$checkout = checkout();
$form     = $this->createForm(DeliveryType::class, DeliveryData::createFrom($checkout))->createView();

-return $this->render('@FrontendBundle/checkout/delivery.html.twig', compact('checkout', 'form'));
+return $this->render('@FrontendBundle/checkout/delivery.html.twig', [
+    'checkout' => $checkout,
+    'form' => $form,
+]);

@TomasVotruba TomasVotruba force-pushed the code-quality-compact branch from cc90af5 to ad95d01 Compare May 19, 2019 08:26
@TomasVotruba TomasVotruba force-pushed the code-quality-compact branch from cb8a156 to ad02742 Compare May 19, 2019 08:29
@TomasVotruba TomasVotruba merged commit 475b875 into master May 19, 2019
@TomasVotruba TomasVotruba deleted the code-quality-compact branch May 19, 2019 08:35
TomasVotruba added a commit that referenced this pull request Dec 9, 2021
rectorphp/rector-src@f068fd9 Fix bug with single configuration item unwrap (#1443)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[code-quality] Replace compact() with real values

1 participant