Fix documentation minor mistake#1493
Fix documentation minor mistake#1493TomasVotruba merged 3 commits intorectorphp:masterfrom alterphp:patch-1
Conversation
|
@TomasVotruba isn't this file autogenerated? (It would mean typo in php code instead) |
|
@JanMikes Yes 👍 @alterphp Please fix it in this file: rector/packages/Symfony/src/Rector/HttpKernel/GetRequestRector.php Lines 49 to 61 in 7bd2d79 Then regenarated docs with: composer docsAnd push, thank you 👍 |
|
@TomasVotruba As you see in 18ca7fb, there is a big diff in the generated doc files... That seems not good to me. WDYT ? |
|
@alterphp Why not? It's the way generated files work. There might be 1 new rule, or changed position, that influences the whole file. Maybe if you use Windows/Mac, the sorting might be affected. But size in the end is ok, so it's ok. |
|
Ok, if it's only a sorting difference, why not. I used the Docker image from the provided Dockerfile to dump them and I work on a Linux environment. |
|
I see. It's out of scope of this PR, I'm just curious. Is is better when you try adding sort here? It should only change your line, there were no new rules since |
|
Thanks for the PR 👍 |
I tried many ways, still a big diff. Are you sure the generated doc in the |
|
Yes. The ordering is inconsistent, see: #1493 (comment) I'll fix it, no troubles |
No description provided.