Skip to content

[PHP] Fix AddDefaultValueForUndefinedVariableRector for static variable #1509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
May 30, 2019
Merged

[PHP] Fix AddDefaultValueForUndefinedVariableRector for static variable #1509

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion packages/Php/src/Rector/FunctionLike/AddDefaultValueForUndefinedVariableRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ public function refactor(Node $node): ?Node
}

$parentNode = $node->getAttribute(AttributeKey::PARENT_NODE);
if ($parentNode instanceof Assign) {
if ($parentNode instanceof Assign || $this->isStaticVariable($parentNode)) {
return null;
}

Expand Down Expand Up @@ -138,4 +138,17 @@ public function refactor(Node $node): ?Node

return $node;
}

private function isStaticVariable(Node $parentNode): bool
{
// definition of static variable
if ($parentNode instanceof Node\Stmt\StaticVar) {
$parentParentNode = $parentNode->getAttribute(AttributeKey::PARENT_NODE);
if ($parentParentNode instanceof Node\Stmt\Static_) {
return true;
}
}

return false;
}
}