[Symfony] Add MakeCommandLazyRector

[TomasVotruba]

Closes #1497

What do you think @stloyd ?

[stloyd]

Overall looks great! Just some small changes needed :)

[TomasVotruba]

I see. So just remove the argument?

[stloyd]

If you find that call with parameter remove just the parameter and you will be safe ;)

[TomasVotruba]

(@stloyd Sorry, I wanted to comment to reply you, but on mobile it dropped me somewhere else)

[stloyd]

First tests are promising :)

[TomasVotruba]

New update 👍

[stloyd]

@TomasVotruba Works almost perfect! Just randomly (like one on 20/30) classes is not getting correct property being set:

325) src/Command/TestCommand.php

    ---------- begin diff ----------
--- Original
+++ New
@@ -16,9 +16,7 @@
 {
     protected function configure()
     {
-        $this
-            ->setName('some:class:long-string-maybe-thats-the-reason-but-probably-not')
-            ->setDescription('do something')
+        $this->setDescription('do something')

Other than this random thing it looks you covered all our legacy cases 👍 🏆

[TomasVotruba]

@stloyd Thanks for deep testing! I think it will not be random.

Do you mean it removes the setName() method correctly but doesn't add the static property?

Could you get me the minimal anonymized PHP code that has this error so I can fix it?

[stloyd]

@TomasVotruba Just check latest version against our legacy codebase with over 400 (don't ask 🤓 ) commands being properly adjusted 😃 🚀

[TomasVotruba]

The more code the bigger amount of work Rector saves 👍

Thanks for testig and feedback. I wouldn't think about those edge cases myself, as I'm biased in single (my :D) approach.

[TomasVotruba]

Lets 🚢 it!