[test] String class name to class constant rector ignore array keys 1539

[Aerendir]

Issue #1539.

[TomasVotruba]

First commit says, that keys are ignored.

Would you add test with namespaces class that proves that?

[Aerendir]

@TomasVotruba no, it is not clear my comment: it says that if I call $var['Exception'], then I get the \Exception object.

But instead, the key is transformed into $var[\Exception::class] and this is not correct: it should remain $var['Exception'], also if Exception is the name of an existent class.

[TomasVotruba]

But instead, the key is transformed into $var[\Exception::class]

This is expected behavior:

-'SomeClass' => new SomeClass
+'SomeClass::class' => new SomeClass

Imagine the 'SomeClass' would be skipped here and during refactoring the SomeClass would be renamed to AnotherClass but the key skipped:

'SomeClass' => new AnotherClass

[Aerendir]

@TomasVotruba , in my case it is not intended as the name of a class but, instead, as a key by which I can get the Exception.

Maybe I need to change the name of my key to something like ExceptionObj 🤔

[TomasVotruba]

Why is it upper class anyway? How do you use it?

[Aerendir]

@TomasVotruba there is no particular reason: I simply wrote it this way 😅.

You are right: I can simply switch to lowercase, am I right?

[TomasVotruba]

I see :) lowercase would be better in this particular case. We'll see how it's used in the wild

[TomasVotruba]

Resolved by #1565

Thanks for the test case