Skip to content

Widen PHPStan version constraint to ~0.11.6.#1548

Merged
TomasVotruba merged 1 commit intorectorphp:masterfrom
Aerendir:widen-phpstan-version-in-composer-1515
Jun 4, 2019
Merged

Widen PHPStan version constraint to ~0.11.6.#1548
TomasVotruba merged 1 commit intorectorphp:masterfrom
Aerendir:widen-phpstan-version-in-composer-1515

Conversation

@Aerendir
Copy link
Copy Markdown
Contributor

@Aerendir Aerendir commented Jun 4, 2019

Issue #1515.

@Aerendir
Copy link
Copy Markdown
Contributor Author

Aerendir commented Jun 4, 2019

There are only two failing tests: one is related to the use of fn that is reserved in PHP7.4.

The other failing test is Rector\RemovingStatic\Tests\Rector\Class_\PassFactoryToEntityRector\PassFactoryToEntityRectorTest but I don't know if it depends by the new version of PHPStan or not.

@TomasVotruba
Copy link
Copy Markdown
Member

TomasVotruba commented Jun 4, 2019

Great, these are not related to the PR.
I'm working on fixing those now.

Thank you for the PR 👍

@TomasVotruba TomasVotruba merged commit 2e5f9f4 into rectorphp:master Jun 4, 2019
@Aerendir Aerendir deleted the widen-phpstan-version-in-composer-1515 branch June 4, 2019 10:25
@enumag
Copy link
Copy Markdown
Contributor

enumag commented Jun 4, 2019

lol, just ran into this too... thanks for having it fixed already, I'll just install dev-master =)

TomasVotruba added a commit that referenced this pull request Dec 27, 2021
@TomasVotruba
Updated Rector to commit 35ef77b
6a7bbbe 
rectorphp/rector-src@35ef77b [Transform][Php81] Add configurable ReturnTypeWillChangeRector (#1548)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Aerendir @TomasVotruba @enumag