Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
use Rector\RectorDefinition\CodeSample;
use Rector\RectorDefinition\RectorDefinition;
use Rector\Util\RectorStrings;
use ReflectionClass;

/**
* @see https://wiki.php.net/rfc/class_name_scalars
Expand All @@ -21,6 +22,16 @@ final class StringClassNameToClassConstantRector extends AbstractRector
*/
private $classesToSkip = [];

/**
* @var string[]
*/
private $sensitiveExistingClasses = [];

/**
* @var string[]
*/
private $sensitiveNonExistingClasses = [];

/**
* @param string[] $classesToSkip
*/
Expand Down Expand Up @@ -80,7 +91,7 @@ public function getNodeTypes(): array
public function refactor(Node $node): ?Node
{
$classLikeName = $node->value;
if (! $this->classLikeExists($classLikeName)) {
if (! $this->classLikeSensitiveExists($classLikeName)) {
return null;
}

Expand All @@ -91,7 +102,33 @@ public function refactor(Node $node): ?Node
return new ClassConstFetch(new FullyQualified($classLikeName), 'class');
}

private function classLikeExists(string $classLikeName): bool
private function classLikeSensitiveExists(string $classLikeName): bool
{
if (! $this->classLikeInsensitiveExists($classLikeName)) {
return false;
}

// already known values
if (in_array($classLikeName, $this->sensitiveExistingClasses, true)) {
return true;
}

if (in_array($classLikeName, $this->sensitiveNonExistingClasses, true)) {
return false;
}

$classReflection = new ReflectionClass($classLikeName);

if ($classLikeName !== $classReflection->getName()) {
$this->sensitiveNonExistingClasses[] = $classLikeName;
return false;
}

$this->sensitiveExistingClasses[] = $classLikeName;
return true;
}

private function classLikeInsensitiveExists(string $classLikeName): bool
{
if (class_exists($classLikeName)) {
return true;
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
<?php

namespace Rector\Php\Tests\Rector\String_\StringClassNameToClassConstantRector\Fixture;

class SkipSensitive
{
public function run()
{
return ['exception' => 'Exception'];
}
}

?>
-----
<?php

namespace Rector\Php\Tests\Rector\String_\StringClassNameToClassConstantRector\Fixture;

class SkipSensitive
{
public function run()
{
return ['exception' => \Exception::class];
}
}

?>
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,11 @@ final class StringClassNameToClassConstantRectorTest extends AbstractRectorTestC
{
public function test(): void
{
$this->doTestFiles([__DIR__ . '/Fixture/fixture.php.inc', __DIR__ . '/Fixture/skip_error.php.inc']);
$this->doTestFiles([
__DIR__ . '/Fixture/fixture.php.inc',
__DIR__ . '/Fixture/skip_error.php.inc',
__DIR__ . '/Fixture/skip_sensitive.php.inc',
]);
}

protected function getRectorClass(): string
Expand Down