[PHP] Fix missed variadic on ReflectionMethod::invoke() [closes #1625]

ecs.yaml

@@ -87,6 +87,7 @@ parameters:
             - 'src/Rector/Annotation/RenameAnnotationRector.php'
             - 'packages/NetteToSymfony/src/Event/EventInfosFactory.php'
             - 'packages/NetteTesterToPHPUnit/src/AssertManipulator.php'
+            - 'src/PhpParser/Node/Manipulator/CallManipulator.php'
 
         Symplify\CodingStandard\Sniffs\CleanCode\ForbiddenStaticFunctionSniff:
             - 'src/Util/*.php'

packages/Php/tests/Rector/FuncCall/RemoveExtraParametersRector/Fixture/skip_invoke.php.inc

@@ -0,0 +1,16 @@
+<?php
+
+namespace Rector\Php\Tests\Rector\FuncCall\RemoveExtraParametersRector\Fixture;
+
+use ReflectionClass;
+
+class SkipInvoke
+{
+    public function run($traitMock)
+    {
+        $reflectionClass = new ReflectionClass('SomeClass');
+        $method = $reflectionClass->getMethod('getSetItems');
+
+        $method->invoke($traitMock, 'some-param', 4, 5, 6);
+    }
+}

packages/Php/tests/Rector/FuncCall/RemoveExtraParametersRector/RemoveExtraParametersRectorTest.php

@@ -19,6 +19,7 @@ public function test(): void
             __DIR__ . '/Fixture/static_call_parent.php.inc',
             __DIR__ . '/Fixture/skip_commented_param_func_get_args.php.inc',
             __DIR__ . '/Fixture/skip_call_user_func_array.php.inc',
+            __DIR__ . '/Fixture/skip_invoke.php.inc',
         ]);
     }
 

src/PhpParser/Node/Manipulator/CallManipulator.php

@@ -78,6 +78,10 @@ public function isVariadic(ReflectionFunctionAbstract $reflectionFunctionAbstrac
             return true;
         }
 
+        if ($this->isVariadicByName($reflectionFunctionAbstract)) {
+            return true;
+        }
+
         if ($reflectionFunctionAbstract instanceof ReflectionFunction) {
             $functionNode = $this->parsedNodesByType->findFunction($reflectionFunctionAbstract->getName());
             if ($functionNode === null) {
@@ -160,4 +164,20 @@ private function resolveMotherType(Node $callNode): string
     {
         return $callNode instanceof FuncCall ? Function_::class : ClassMethod::class;
     }
+
+    /**
+     * native PHP bug fix
+     */
+    private function isVariadicByName(ReflectionFunctionAbstract $reflectionFunctionAbstract): bool
+    {
+        if (! $reflectionFunctionAbstract instanceof ReflectionMethod) {
+            return false;
+        }
+
+        if ($reflectionFunctionAbstract->getDeclaringClass()->getName() !== 'ReflectionMethod') {
+            return false;
+        }
+
+        return $reflectionFunctionAbstract->getName() === 'invoke';
+    }
 }