Skip to content

[MakeCommandLazyRector] Remove duplicated check #1679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Jul 3, 2019
Merged

[MakeCommandLazyRector] Remove duplicated check #1679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions packages/Symfony/src/Rector/Class_/MakeCommandLazyRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,26 +136,6 @@ private function resolveCommandNameAndRemove(Class_ $class): ?Node
}
}

if ($node instanceof ClassMethod && $this->isName($node, '__construct')) {
if (count((array) $node->stmts) !== 1) {
return null;
}

$onlyNode = $node->stmts[0];
if ($onlyNode instanceof Expression) {
$onlyNode = $onlyNode->expr;

$commandName = $this->matchCommandNameNodeInConstruct($onlyNode);
if ($commandName === null) {
return null;
}

if (count($node->params) === 0) {
$this->removeNode($node);
}
}
}

if ($node instanceof StaticCall) {
if (! $this->isType($node, self::COMMAND_CLASS)) {
return null;
Expand Down