Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,13 @@ public function refactor(Node $node): ?Node
}
} else {
$paramNode->type = $paramTypeInfo->getTypeNode();

// "resource" is valid phpdoc type, but it's not implemented in PHP
if ($paramNode->type instanceof Node\Name && reset($paramNode->type->parts) === 'resource') {
$paramNode->type = null;

continue;
}
}

$this->populateChildren($node, $position, $paramTypeInfo);
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<?php

namespace Rector\TypeDeclaration\Tests\Rector\ClassMethod\ParamTypeDeclarationRector\Fixture;

class ResourceTypes
{
/**
* @param resource $value
*/
public function someFunction($value)
{
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ public function test(): void
// various
__DIR__ . '/Fixture/variadic.php.inc',
__DIR__ . '/Fixture/mixed.php.inc',
__DIR__ . '/Fixture/resource.php.inc',
__DIR__ . '/Fixture/trait_interface.php.inc',
__DIR__ . '/Fixture/this.php.inc',
__DIR__ . '/Fixture/false.php.inc',
Expand Down