[DeadCode] Allow static constant call on RemoveUnusedPrivateConstantRector#1697
Merged
TomasVotruba merged 2 commits intorectorphp:masterfrom Jul 6, 2019
ravanscafi:static-constant-call
Merged
[DeadCode] Allow static constant call on RemoveUnusedPrivateConstantRector#1697TomasVotruba merged 2 commits intorectorphp:masterfrom ravanscafi:static-constant-call
TomasVotruba merged 2 commits intorectorphp:masterfrom
ravanscafi:static-constant-call
Conversation
ravanscafi
changed the title
Member
|
Thank you 👍 |
TomasVotruba
added a commit
that referenced
this pull request
Jan 19, 2022
rectorphp/rector-src@7d92627 [Php56] Skip AddDefaultValueForUndefinedVariableRector on empty() check (#1697)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically there were false positives regarding private constant uses when called with
static::instead ofself::Note:
phpstanis failing on master too. I've fixed it on #1698