[FuncCall] Don't add $result to parse_str if second parameter is already set#1709
Merged
TomasVotruba merged 1 commit intorectorphp:masterfrom Jul 9, 2019
ravanscafi:valid-parse-str
Merged
[FuncCall] Don't add $result to parse_str if second parameter is already set#1709TomasVotruba merged 1 commit intorectorphp:masterfrom ravanscafi:valid-parse-str
TomasVotruba merged 1 commit intorectorphp:masterfrom
ravanscafi:valid-parse-str
Conversation
TomasVotruba
reviewed
Jul 9, 2019
| } | ||
| } | ||
|
|
||
| ?> |
Member
There was a problem hiding this comment.
If the code should have no change, you can keep only the first part (above ----):
<?php
namespace Rector\Php\Tests\Rector\FuncCall\ParseStrWithResultArgumentRector\Fixture;
class AlreadySet
{
public function run()
{
$query = 'bla';
parse_str($query, $data);
}
}
?>
------
-<?php
-
-namespace Rector\Php\Tests\Rector\FuncCall\ParseStrWithResultArgumentRector\Fixture;
-
-class AlreadySet
-{
- public function run()
- {
- $query = 'bla';
- parse_str($query, $data);
- }
-}
-?>
Member
There was a problem hiding this comment.
Also, the standard here is to prefix these test cases with skip_.
That way we can group them visually by fix and skip groups
Here skip_already_set.php.inc.
Member
|
On second though, these details are not related to the feature and can be cleared later in chunk, so thanks for the PR! Merging ✔️ |
TomasVotruba
added a commit
that referenced
this pull request
Jan 21, 2022
rectorphp/rector-src@f0928ab [cleanup] remove historical and unsupported safe 0.7 (#1709)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this fix,
parse_str($query, $data);would turn intoparse_str($query, $result);by no reason, breaking valid code.