Skip to content

[MethodCall] Fix multilevel array subsets#1710

Merged
TomasVotruba merged 1 commit intorectorphp:masterfrom
ravanscafi:multilevel-array-subset
Jul 9, 2019
Merged

[MethodCall] Fix multilevel array subsets#1710
TomasVotruba merged 1 commit intorectorphp:masterfrom
ravanscafi:multilevel-array-subset

Conversation

@ravanscafi
Copy link
Copy Markdown
Contributor

@ravanscafi ravanscafi commented Jul 8, 2019

When multi-level arrays were used, an error was thrown:

Error: Call to undefined method PHPStan\Type\Constant\ConstantArrayType::getValue()

/rector/src/PhpParser/Node/Value/ValueResolver.php:181
/rector/src/PhpParser/Node/Value/ValueResolver.php:75
/rector/src/Rector/AbstractRector/ValueResolverTrait.php:32
/rector/packages/PHPUnit/src/Rector/MethodCall/ReplaceAssertArraySubsetRector.php:174
/rector/packages/PHPUnit/src/Rector/MethodCall/ReplaceAssertArraySubsetRector.php:89

@TomasVotruba TomasVotruba merged commit 0279ce0 into rectorphp:master Jul 9, 2019
@TomasVotruba
Copy link
Copy Markdown
Member

TomasVotruba commented Jul 9, 2019

Thank you 👍

@ravanscafi ravanscafi deleted the multilevel-array-subset branch July 9, 2019 14:10
TomasVotruba added a commit that referenced this pull request Jan 21, 2022
@TomasVotruba
Updated Rector to commit 369c2f7
62081a0 
rectorphp/rector-src@369c2f7 [CodeQuality][EarlyReturn] Handle SimplifyIfElseToTernaryRector + ChangeIfElseValueAssignToEarlyReturnRector (#1710)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ravanscafi @TomasVotruba