Do not mark injected properties as private when moved to constructor

[holtkamp]

As suggested in #1400 (comment)

[TomasVotruba]

What about classes with no children?

[holtkamp]

As mentioned here #1400 (comment), I do not think "detecting" this is the responsibility of this rector...? Better to have a lot of small and focussed rectors and let them work together, right?

[TomasVotruba]

Great approach and usually I'd agree.

I try to look at this from users perspective - what would they change in code at one go?
Would they not care about visibility?

[holtkamp]

Well, from my user-perspective: in case I have marked my property as public or protected, this has a reason...

Of course, in case rector can determine properly that the visibility can be set to private, this would be great. However: I do not know how to determine that reliable, so I choose the easy way 😄

In case it is possible for rector to determine whether:

• a public property is used by by other code
• a protected property is used by specializing classes

=> then this could be added. But I "assumed" this would be possibly get quite complex?

[TomasVotruba]

I see. Thanks for explaning your point of view. It helped me to improve my pespective :)

Let's try your idea and see how it goes.

[TomasVotruba]

Thanks for the PR!