Consider reference symbol in docblock for param type declaration rector#1735
Merged
TomasVotruba merged 1 commit intorectorphp:masterfrom Jul 15, 2019
Merged
Conversation
Member
|
I'll look at it, thanks for failing test and propsed solution 👍 |
TomasVotruba
added a commit
that referenced
this pull request
Jan 27, 2022
rectorphp/rector-src@c6142e1 [Php56][Php70] Handle ExceptionHandlerTypehintRector+CatchExceptionNameMatchingTypeRector+AddDefaultValueForUndefinedVariableRector (#1735)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked to #1734
The idea here would be to ignore the
&during parsing. Unfortunately in this case, rector depends on phpstan doc parser which maintainers decided not to support this type of documenting: phpstan/phpstan#699I've dug a little and found that adding this line:
After this line:
https://github.com/phpstan/phpdoc-parser/blob/master/src/Parser/PhpDocParser.php#L166
Would effectively ignore it and make the test green.
I'm wondering if there could be any workaround that can be put in rector code directly.