add reference support to ParamTypeDeclarationRector#1744
Merged
TomasVotruba merged 1 commit intomasterfrom Jul 15, 2019
Merged
Conversation
TomasVotruba
force-pushed
the
doc-reference-parser
branch
2 times, most recently
from
e0576cb to
29e4b14
Compare
Member
Author
|
@tigitz What do you think about this? |
TomasVotruba
force-pushed
the
doc-reference-parser
branch
from
29e4b14 to
48449ee
Compare
|
@TomasVotruba awesome! Thanks, I almost feel bad requiring that amount of complexity to handle such a specific use case 😅 |
Member
Author
|
If it becomes a performance issue, we can always improve it :) That's the price of open source. Some people don't care about problem, so you have to take a way around it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #1734