Skip to content

[CodeQuality] Fix CompleteDynamicPropertiesRector for dynamic property fetch#1752

Merged
TomasVotruba merged 1 commit intomasterfrom
dynamic-invalid-name
Jul 19, 2019
Merged

[CodeQuality] Fix CompleteDynamicPropertiesRector for dynamic property fetch#1752
TomasVotruba merged 1 commit intomasterfrom
dynamic-invalid-name

Conversation

@TomasVotruba
Copy link
Copy Markdown
Member

Closes #1751

@TomasVotruba TomasVotruba force-pushed the dynamic-invalid-name branch from 0034b3f to e8b5a11 Compare July 19, 2019 14:01
Copy link
Copy Markdown
Contributor

@stloyd stloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@TomasVotruba TomasVotruba merged commit 361c9eb into master Jul 19, 2019
@TomasVotruba TomasVotruba deleted the dynamic-invalid-name branch July 19, 2019 14:09
@TomasVotruba TomasVotruba restored the dynamic-invalid-name branch August 6, 2019 07:20
@TomasVotruba TomasVotruba deleted the dynamic-invalid-name branch August 6, 2019 07:20
TomasVotruba added a commit that referenced this pull request Feb 15, 2022
rectorphp/rector-src@7d8444e [TypeDeclaration] Skip @inheritdoc on PropertyTypeDeclaration (#1752)
TomasVotruba added a commit that referenced this pull request Feb 15, 2022
rectorphp/rector-src@7d8444e [TypeDeclaration] Skip @inheritdoc on PropertyTypeDeclaration (#1752)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CodeQuality] CompleteDynamicPropertiesRector add unknown property

2 participants