Skip to content

[DeadCode] Rector RemoveDeadConstructorRector should skip private method #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Jul 19, 2019
Merged

[DeadCode] Rector RemoveDeadConstructorRector should skip private method #1753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/DeadCode/src/Rector/ClassMethod/RemoveDeadConstructorRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,11 @@ public function refactor(Node $node): ?Node
return null;
}

// Skip private as they lock creating new instances via `new ClassName()`
if ($node->isPrivate()) {
return null;
}

$this->removeNode($node);

return null;
Expand Down
10 changes: 10 additions & 0 deletions ...eadCode/tests/Rector/ClassMethod/RemoveDeadConstructorRector/Fixture/skip_private.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php

namespace Rector\DeadCode\Tests\Rector\ClassMethod\RemoveDeadConstructorRector\Fixture;

class SkipPrivate
{
private function __construct()
{
}
}
8 changes: 7 additions & 1 deletion .../tests/Rector/ClassMethod/RemoveDeadConstructorRector/RemoveDeadConstructorRectorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,13 @@ final class RemoveDeadConstructorRectorTest extends AbstractRectorTestCase
{
public function test(): void
{
$this->doTestFiles([__DIR__ . '/Fixture/fixture.php.inc', __DIR__ . '/Fixture/skip.php.inc']);
$this->doTestFiles(
[
__DIR__ . '/Fixture/fixture.php.inc',
__DIR__ . '/Fixture/skip.php.inc',
__DIR__ . '/Fixture/skip_private.php.inc',
]
);
}

protected function getRectorClass(): string
Expand Down