fix non-same parent method name for RemoveParentCallWithoutParentRector

packages/DeadCode/src/Rector/StaticCall/RemoveParentCallWithoutParentRector.php

@@ -82,7 +82,8 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
-        if ($this->classMethodManipulator->hasParentMethodOrInterfaceMethod($methodNode)) {
+        $calledMethodName = $this->getName($node->name);
+        if ($this->classMethodManipulator->hasParentMethodOrInterfaceMethod($methodNode, $calledMethodName)) {
             return null;
         }
 

packages/DeadCode/tests/Rector/StaticCall/RemoveParentCallWithoutParentRector/Fixture/edge_case.php.inc

@@ -0,0 +1,19 @@
+<?php
+
+namespace Rector\DeadCode\Tests\Rector\StaticCall\RemoveParentCallWithoutParentRector\Fixture;
+
+class EdgeCase extends AbstractFilterFactory
+{
+    public function getOrderByIdDesc()
+    {
+        return parent::getOrderByColumnDesc('id');
+    }
+}
+
+abstract class AbstractFilterFactory
+{
+    public function getOrderByColumnDesc(string $column)
+    {
+        return new OrderByDesc($column);
+    }
+}

packages/DeadCode/tests/Rector/StaticCall/RemoveParentCallWithoutParentRector/RemoveParentCallWithoutParentRectorTest.php

@@ -13,6 +13,7 @@ public function test(): void
             __DIR__ . '/Fixture/fixture.php.inc',
             __DIR__ . '/Fixture/parent_but_no_method.php.inc',
             __DIR__ . '/Fixture/skip_trait.php.inc',
+            __DIR__ . '/Fixture/edge_case.php.inc',
         ]);
     }
 

src/PhpParser/Node/Manipulator/ClassMethodManipulator.php

@@ -90,29 +90,30 @@ public function isParameterUsedMethod(Param $param, ClassMethod $classMethod): b
         return $this->nameResolver->isNames($param, $arguments);
     }
 
-    public function hasParentMethodOrInterfaceMethod(ClassMethod $classMethod): bool
+    public function hasParentMethodOrInterfaceMethod(ClassMethod $classMethod, ?string $methodName = null): bool
     {
+        $methodName = $methodName ?? $this->nameResolver->getName($classMethod->name);
+
         $class = $classMethod->getAttribute(AttributeKey::CLASS_NAME);
         if (! is_string($class)) {
             return false;
         }
 
-        $method = $classMethod->getAttribute(AttributeKey::METHOD_NAME);
-        if (! is_string($method)) {
+        if (! class_exists($class)) {
             return false;
         }
 
-        if (! class_exists($class)) {
+        if (! is_string($methodName)) {
             return false;
         }
 
-        if ($this->isMethodInParent($class, $method)) {
+        if ($this->isMethodInParent($class, $methodName)) {
             return true;
         }
 
         $implementedInterfaces = class_implements($class);
         foreach ($implementedInterfaces as $implementedInterface) {
-            if (method_exists($implementedInterface, $method)) {
+            if (method_exists($implementedInterface, $methodName)) {
                 return true;
             }
         }
@@ -186,9 +187,7 @@ public function addMethodParameterIfMissing(Node $node, string $type, array $pos
 
     private function isMethodInParent(string $class, string $method): bool
     {
-        $parentClass = $class;
-
-        while ($parentClass = get_parent_class($parentClass)) {
+        foreach (class_parents($class) as $parentClass) {
             if (method_exists($parentClass, $method)) {
                 return true;
             }